-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lgtvserial] Fix sending commands using serial port #11776
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Primo <[email protected]> Signed-off-by: carlospg79 <[email protected]>
carlospg79
force-pushed
the
bugfix-lgtvserial-binding
branch
from
December 14, 2021 15:39
6440a54
to
5a3559c
Compare
lolodomo
approved these changes
Dec 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wborn
changed the title
[lgtvserial] Fixes #8646 - fix binding for recent openHab versions
[lgtvserial] Fix sending commands using serial port
Dec 18, 2021
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Dec 30, 2021
Signed-off-by: Carlos Primo <[email protected]> Signed-off-by: carlospg79 <[email protected]> Signed-off-by: Nick Waterton <[email protected]>
mischmidt83
pushed a commit
to mischmidt83/openhab-addons
that referenced
this pull request
Jan 9, 2022
Signed-off-by: Carlos Primo <[email protected]> Signed-off-by: carlospg79 <[email protected]> Signed-off-by: Michael Schmidt <[email protected]>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
Signed-off-by: Carlos Primo <[email protected]> Signed-off-by: carlospg79 <[email protected]>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
Signed-off-by: Carlos Primo <[email protected]> Signed-off-by: carlospg79 <[email protected]>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
Signed-off-by: Carlos Primo <[email protected]> Signed-off-by: carlospg79 <[email protected]>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
Signed-off-by: Carlos Primo <[email protected]> Signed-off-by: carlospg79 <[email protected]> Signed-off-by: Andras Uhrin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to fix bugs mentioned in #8646 about the problems to be able to send command to LG tv through serial port.
Bugfix for lg tv serial binding for greather versions of openHAB than 2.5
In previous versions of openHab <=2.4 the binding runs succesfully and can send commands to tv. But after upgrading openHAB, it didn't work anymore.
After debugging original component, I detected two bugs.
The problem here, is that sometime reading from serial port don't send anything or timeout until the device writes something, resulting in a thread blocked waiting for a read.
I tried to fix it adding a
while (input.available() > 0 && (data = input.read()) > -1) {
where input.available() returns remaining characters on the buffer.